Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): Disable integration tests for project id #3087

Merged
merged 2 commits into from Oct 27, 2020

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Oct 26, 2020

The Pub/Sub Lite server currently only supports project numbers in resource paths. It will also accept project ids by EOQ4, 2020. We didn't want to implement any special logic in the new Lite client libraries.

@tmdiep tmdiep requested a review from googleapis/yoshi-go-admins as a code owner Oct 26, 2020
@google-cla google-cla bot added the cla: yes label Oct 26, 2020
@tmdiep tmdiep linked an issue that may be closed by this pull request Oct 26, 2020
@hongalex hongalex merged commit a0982f7 into googleapis:master Oct 27, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@tmdiep tmdiep deleted the tmdiep:fix_tests branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants