fix(logging): Entries has a 24H default filter#3120
Merged
freelerobot merged 7 commits intomasterfrom Apr 7, 2021
Merged
Conversation
BREAKING CHANGE: significantly speeds up call to list log entries
freelerobot
added
type: feature request
google-cla
Bot
added
the
cla: yes
codyoss
requested changes
Nov 2, 2020
Member
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
I have a couple of questions about these changes, raised internally.
Contributor
Author
|
After discussion: we'll batch this change with future improvements |
freelerobot
added
the
do not merge
simonz130
reviewed
Nov 3, 2020
freelerobot
changed the title
freelerobot
removed
the
do not merge
freelerobot
changed the title
codyoss
approved these changes
Apr 7, 2021
Member
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
Seems reasonable and a more desirable behavior. It looks like this was also considered a non-breaking change in the node libraries.
freelerobot
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.4.0](https://www.github.com/googleapis/google-cloud-go/compare/logging/v1.2.0...logging/v1.4.0) (2021-04-15) ### Features * **logging:** cloud run and functions resource autodetection ([#3909](https://www.github.com/googleapis/google-cloud-go/issues/3909)) ([1204de8](https://www.github.com/googleapis/google-cloud-go/commit/1204de85e58334bf93fecdcb0ab8b581449c2745)) * **logging:** make toLogEntry function public ([#3863](https://www.github.com/googleapis/google-cloud-go/issues/3863)) ([71828c2](https://www.github.com/googleapis/google-cloud-go/commit/71828c28d424c34da6d0392651739a364cd57e79)) ### Bug Fixes * **logging:** Entries has a 24H default filter ([#3120](https://www.github.com/googleapis/google-cloud-go/issues/3120)) ([b32eb82](https://www.github.com/googleapis/google-cloud-go/commit/b32eb822d17838bde91c610a5a9d392d325a592d)) This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would like to push this through as a minor feat, and a nonbreaking change. User's existing code will actually not be broken by the PR. Users will simply retrieve less logs upon running listEntries. Previously, users would have hit API quota anyway. This is more a bug fix than a new feature
fixes: #3088