Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): Periodic background task #3152

merged 4 commits into from Nov 6, 2020


Copy link

@tmdiep tmdiep commented Nov 6, 2020

Introduces periodicTask to manage a recurring background task that can be paused and resumed.

@tmdiep tmdiep requested a review from as a code owner Nov 6, 2020
@google-cla google-cla bot added the cla: yes label Nov 6, 2020
@tmdiep tmdiep requested a review from hongalex Nov 6, 2020
Copy link
Contributor Author

@tmdiep tmdiep commented Nov 6, 2020

Ugh, sorry. I failed to notice that Ticker.Reset is not supported before Go 1.15, so had to reduce the interface to just Start/Stop. This also ended up resolving your comment about duplicate starts.

PTAL, thanks!

@tmdiep tmdiep requested a review from hongalex Nov 6, 2020
Copy link

@hongalex hongalex commented Nov 6, 2020

Ah yeah good catch. I thought it was just tests being flaky

@hongalex hongalex merged commit 58c12cc into googleapis:master Nov 6, 2020
3 checks passed
@tmdiep tmdiep deleted the task branch Nov 6, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 10, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [0.3.0]( (2020-11-10)

### Features

* **pubsublite:** Added Pub/Sub Lite clients and routing headers ([#3105]( ([98668fa](
* **pubsublite:** Flow controller and offset tracker for the subscriber ([#3132]( ([5899bdd](
* **pubsublite:** Mock server and utils for unit tests ([#3092]( ([586592e](
* **pubsublite:** Move internal implementation details to internal/wire subpackage ([#3123]( ([ed3fd1a](
* **pubsublite:** Periodic background task ([#3152]( ([58c12cc](
* **pubsublite:** Test utils for streams ([#3153]( ([5bb2b02](
* **pubsublite:** Trackers for acks and commit cursor ([#3137]( ([26599a0](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants