Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): Enable server side flow control by default with the option to turn it off #3154

Merged
merged 11 commits into from Nov 11, 2020

Conversation

@fayssalmartanigcp
Copy link
Contributor

@fayssalmartanigcp fayssalmartanigcp commented Nov 6, 2020

This change enables sending flow control settings automatically to the server.
If ReceiveSettings.MaxOutstandingMessages > 0 or ReceiveSettings.MaxOutstandingBytes > 0,
flow control will be enforced at the server side (in addition to the client side).

This behavior is enabled by default and ReceiveSettings.UseLegacyFlowControl can be set for users
who would like to opt-out of this feature in case they encounter issues with server side flow
control.

…urn it off

This change enables sending flow control settings automatically to the server.
If ReceiveSettings.MaxOutstandingMessages > 0 or ReceiveSettings.MaxOutstandingBytes > 0,
flow control will be enforced at the server side (in addition to the client side).

This behavior is enabled by default and ReceiveSettings.UseLegacyFlowControl can be set for users
who would like to opt-out of this feature in case they encounter issues with server side flow
control.
@google-cla google-cla bot added the cla: yes label Nov 6, 2020
@fayssalmartanigcp fayssalmartanigcp marked this pull request as ready for review Nov 6, 2020
@codyoss codyoss changed the title feat: Enable server side flow control by default with the option to turn it off feat(pubsub): Enable server side flow control by default with the option to turn it off Nov 6, 2020
@codyoss
Copy link
Member

@codyoss codyoss commented Nov 6, 2020

@fayssalmartanigcp Thank you for the contribution. Is there an issue associated with this PR, if not would you mind opening one?

Loading

@codyoss codyoss requested a review from hongalex Nov 6, 2020
pubsub/subscription.go Outdated Show resolved Hide resolved
Loading
pubsub/iterator.go Outdated Show resolved Hide resolved
Loading
@hongalex hongalex requested a review from as a code owner Nov 10, 2020
pubsub/iterator.go Outdated Show resolved Hide resolved
Loading
@hongalex hongalex merged commit e392e61 into googleapis:master Nov 11, 2020
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants