Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/gapicgen): support adding context to regen #3174

Merged
merged 6 commits into from Dec 3, 2020

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Nov 9, 2020

Now all regen PRs will include a block that mentions all of the
changes that happened in googleapis/googleapis that caused the
files to be generated. This information will eventually be fed
into our automated releases via release-please. There these changes
will be parsed out to add extra context to our release PRs and
changelogs. No longer will we have to have a vague message about
many auto-generated changes.

  • Adds context to regen PRs.
  • Refactored generators so every method does not need so many
    parameters.
  • Updated goolge/protobuf to its new migrated repo
    protocolbuffers/protobuf.
  • Added some extra logging to the build.
  • Only run protoc on dirs that have changes.
codyoss added 2 commits Nov 9, 2020
Now all regen PRs will include a block that mentions all of the
changes that happened in googleapis/googleapis that caused the
files to be generated. This information will eventually be fed
into our automated releases via release-please. There these changes
will be parsed out to add extra context to our release PRs and
changelogs. No longer will we have to have a vague message about
many auto-generated changes.

- Adds context to regen PRs.
- Refactored generators so every method does not need so many
  parameters.
- Updated goolge/protobuf to its new migrated repo
  protocolbuffers/protobuf.
- Added some extra logging to the build.
- Only run protoc on dirs that have changes.
@google-cla google-cla bot added the cla: yes label Nov 9, 2020
@codyoss codyoss marked this pull request as ready for review Nov 9, 2020
@codyoss codyoss requested a review from googleapis/yoshi-go-admins as a code owner Nov 9, 2020
@codyoss
Copy link
Member Author

@codyoss codyoss commented Nov 9, 2020

Here is a sample of what regen PRs look like with these changes: googleapis/go-genproto#486 & #3171. They were generated by building and running the dockerfile, genbot, with local changes mounted in.

internal/gapicgen/cmd/genbot/generate.go Outdated Show resolved Hide resolved
internal/gapicgen/cmd/genbot/github.go Outdated Show resolved Hide resolved
internal/gapicgen/generator/generator.go Outdated Show resolved Hide resolved
internal/gapicgen/generator/config.go Outdated Show resolved Hide resolved
internal/gapicgen/generator/config.go Outdated Show resolved Hide resolved
@codyoss codyoss requested a review from tbpg Nov 10, 2020
@tbpg
tbpg approved these changes Nov 10, 2020
internal/gapicgen/cmd/genbot/github.go Outdated Show resolved Hide resolved
internal/gapicgen/cmd/genbot/github.go Outdated Show resolved Hide resolved
@codyoss codyoss merged commit 941ab02 into googleapis:master Dec 3, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@codyoss codyoss deleted the codyoss:context-aware-commits branch Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants