feat(internal/gapicgen): support adding context to regen#3174
Merged
codyoss merged 6 commits intogoogleapis:masterfrom Dec 3, 2020
codyoss:context-aware-commits
Merged
feat(internal/gapicgen): support adding context to regen#3174codyoss merged 6 commits intogoogleapis:masterfrom codyoss:context-aware-commits
codyoss merged 6 commits intogoogleapis:masterfrom
codyoss:context-aware-commits
Conversation
Now all regen PRs will include a block that mentions all of the changes that happened in googleapis/googleapis that caused the files to be generated. This information will eventually be fed into our automated releases via release-please. There these changes will be parsed out to add extra context to our release PRs and changelogs. No longer will we have to have a vague message about many auto-generated changes. - Adds context to regen PRs. - Refactored generators so every method does not need so many parameters. - Updated goolge/protobuf to its new migrated repo protocolbuffers/protobuf. - Added some extra logging to the build. - Only run protoc on dirs that have changes.
google-cla
bot
added
the
cla: yes
Member
Author
|
Here is a sample of what regen PRs look like with these changes: googleapis/go-genproto#486 & #3171. They were generated by building and running the dockerfile, genbot, with local changes mounted in. |
tbpg
suggested changes
Nov 10, 2020
tbpg
approved these changes
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now all regen PRs will include a block that mentions all of the
changes that happened in googleapis/googleapis that caused the
files to be generated. This information will eventually be fed
into our automated releases via release-please. There these changes
will be parsed out to add extra context to our release PRs and
changelogs. No longer will we have to have a vague message about
many auto-generated changes.
parameters.
protocolbuffers/protobuf.