Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): define structures and parse UPDATE DML statements #3192

Merged
merged 1 commit into from Nov 11, 2020

Conversation

@dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Nov 10, 2020

Updates #3162.

@dsymonds dsymonds requested review from skuruppu and olavloite Nov 10, 2020
@dsymonds dsymonds requested a review from as a code owner Nov 10, 2020
@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@dsymonds dsymonds force-pushed the spansql-update-dml branch 2 times, most recently from b4058be to c1adff9 Nov 10, 2020
Copy link
Collaborator

@olavloite olavloite left a comment

The current implementation does not seem to support setting a column to NULL. I'm happy with regarding that as a TODO, as this would probably already help people a lot.

Loading

spanner/spansql/parser.go Show resolved Hide resolved
Loading
spanner/spansql/sql_test.go Show resolved Hide resolved
Loading
@dsymonds dsymonds force-pushed the spansql-update-dml branch from c1adff9 to 3508b88 Nov 11, 2020
@dsymonds dsymonds changed the title spanner/spansql: define structures and parse UPDATE DML statements feat(spanner/spansql): define structures and parse UPDATE DML statements Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 23b6904 into googleapis:master Nov 11, 2020
3 checks passed
Loading
@dsymonds dsymonds deleted the spansql-update-dml branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants