Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/godocfx): filter out test packages from other modules #3197

Merged
merged 1 commit into from Nov 11, 2020

Conversation

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Nov 11, 2020

Test packages don't have module set, so they aren't filtered out in the
existing check. The order of packages isn't defined as far as I can
tell. So, we may not know to skip a package when we first see it.

Test packages don't have module set, so they aren't filtered out in the
existing check. The order of packages isn't defined as far as I can
tell. So, we may not know to skip a package when we first see it.
@tbpg tbpg requested a review from tritone Nov 11, 2020
@tbpg tbpg requested a review from googleapis/yoshi-go-admins as a code owner Nov 11, 2020
@google-cla google-cla bot added the cla: yes label Nov 11, 2020
@tbpg tbpg added the automerge label Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1d397aa into master Nov 11, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@gcf-merge-on-green gcf-merge-on-green bot deleted the godocfx-filter branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants