Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spannertest): implement FULL JOIN #3218

Merged

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Nov 17, 2020

This doesn't fit into the same structure as the other JOINs, but is
approximately implemented as a LEFT JOIN with a catchup phase of
emitting the unmatched RHS rows.

@dsymonds dsymonds added the api: spanner Issues related to the Cloud Spanner API. label Nov 17, 2020
@dsymonds dsymonds requested a review from olavloite Nov 17, 2020
@dsymonds dsymonds requested review from skuruppu and a team as code owners Nov 17, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2020
This doesn't fit into the same structure as the other JOINs, but is
approximately implemented as a LEFT JOIN with a catchup phase of
emitting the unmatched RHS rows.
@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Nov 18, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 99f7212 into googleapis:master Nov 18, 2020
2 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 18, 2020
@dsymonds dsymonds deleted the spannertest-full-join branch Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants