Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): single partition publisher implementation #3225

Merged
merged 8 commits into from Nov 25, 2020

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Nov 18, 2020

Implements the publisher for a single partition. A Bundler is used to batch messages.

singlePartitionPublisher is equivalent to PublisherImpl in the Pub/Sub Lite Java client library.

Implements the publisher for a single partition.
@tmdiep tmdiep force-pushed the single_publisher branch from a247e5d to dc47e4b Nov 18, 2020
@tmdiep tmdiep marked this pull request as ready for review Nov 18, 2020
@tmdiep tmdiep requested a review from as a code owner Nov 18, 2020
@tmdiep
Copy link
Contributor Author

@tmdiep tmdiep commented Nov 18, 2020

WANT_LGTM=@dpcollins-google
Other reviewers optional, but feel free to leave comments.

pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publisher.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publisher.go Show resolved Hide resolved
pubsublite/internal/wire/publish_data.go Outdated Show resolved Hide resolved
@tmdiep tmdiep requested a review from dpcollins-google Nov 19, 2020
Copy link

@dpcollins-google dpcollins-google left a comment

Approved, but not actually approving. Going to leave for hongalex@ to provide golang approval (I have written ~2000 lines of golang in my life)

@tmdiep tmdiep changed the title feat(pubsublite): Single partition publisher feat(pubsublite): single partition publisher implementation Nov 24, 2020
@tmdiep tmdiep force-pushed the single_publisher branch from d72b59f to 2dc00b4 Nov 24, 2020
pubsublite/internal/wire/publish_batcher.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_batcher_test.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/publish_batcher.go Outdated Show resolved Hide resolved
Copy link
Member

@hongalex hongalex left a comment

LGTM pending CI

@tmdiep tmdiep merged commit 4982eeb into googleapis:master Nov 25, 2020
3 checks passed
@tmdiep tmdiep deleted the single_publisher branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants