Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): assigning subscriber implementation #3238

Merged
merged 8 commits into from Dec 7, 2020

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Nov 19, 2020

assigningSubscriber uses the Pub/Sub Lite partition assignment service to listen to its assigned partition numbers and dynamically add/remove singlePartitionSubscribers.

@tmdiep
Copy link
Contributor Author

@tmdiep tmdiep commented Nov 19, 2020

WANT_LGTM=@dpcollins-google for checking assigner and assigningSubscriber logic.
Other reviewers optional. Feel free to leave comments.

@tmdiep tmdiep changed the title feat(pubsublite): Assigning subscriber feat(pubsublite): assigning subscriber implementation Nov 24, 2020
@tmdiep tmdiep force-pushed the subscriber2 branch 2 times, most recently from 92d9cd8 to 71ab99c Nov 28, 2020
Copy link

@dpcollins-google dpcollins-google left a comment

LGTM after changes from a pub/sub lite perspective, I'd prefer if you get someone familiar with go to review as well.

pubsublite/internal/wire/assigner.go Show resolved Hide resolved
pubsublite/internal/wire/assigner.go Show resolved Hide resolved
pubsublite/internal/wire/assigner.go Show resolved Hide resolved
pubsublite/internal/wire/subscriber.go Show resolved Hide resolved
@tmdiep
Copy link
Contributor Author

@tmdiep tmdiep commented Dec 2, 2020

WANT_LGTM=@hongalex for Go, and also Dan doesn't have write access and can't approve anyway.

@tmdiep tmdiep merged commit d1c03da into googleapis:master Dec 7, 2020
3 checks passed
@tmdiep tmdiep deleted the subscriber2 branch Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants