Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): expose hive partitioning options #3240

Merged
merged 6 commits into from Nov 20, 2020

Conversation

@shollyman
Copy link
Contributor

@shollyman shollyman commented Nov 19, 2020

This PR resuscitates https://code-review.googlesource.com/c/gocloud/+/43270
and updates it with additional functionality that was previously not properly exposed
such as RequirePartitionFilter.

This also adds a quick integration test as table creation validates the layout, and issues
an example query that leverages the hive partitioning layout to prune reading.

shollyman added 3 commits Oct 24, 2020
This resuscitates https://code-review.googlesource.com/c/gocloud/+/43270
and updates it now that the service is properly advertising the fields
such as RequirePartitionFilter.
@shollyman shollyman requested a review from as a code owner Nov 19, 2020
@google-cla google-cla bot added the cla: yes label Nov 19, 2020
@shollyman shollyman requested a review from hongalex Nov 19, 2020
bigquery/external.go Outdated Show resolved Hide resolved
Loading
bigquery/external.go Outdated Show resolved Hide resolved
Loading
@hongalex
Copy link
Member

@hongalex hongalex commented Nov 20, 2020

LGTM pending tests green (saw you just pushed a commit fixing the exported var issue )

Loading

@shollyman shollyman merged commit fa77efa into googleapis:master Nov 20, 2020
3 checks passed
Loading
@shollyman shollyman deleted the fr-hivepartitioning2 branch Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants