Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): Add support for RPC priority #3341

Merged
merged 12 commits into from Mar 31, 2021
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Dec 3, 2020

Adds support for setting a priority per RPC. This can be any read/query/update statement and it can be set for a commit RPC.

olavloite added 4 commits Dec 3, 2020
Adds support for setting a priority per RPC. This can be any read/query/update
statement and it can be set for a commit RPC.
@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 3, 2020
@olavloite olavloite requested a review from skuruppu Dec 3, 2020
@olavloite olavloite requested a review from a team as a code owner Dec 3, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Dec 3, 2020
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 26, 2021
@olavloite
Copy link
Contributor Author

olavloite commented Mar 26, 2021

@skuruppu and @larkee Please take a final look, this should now also be ready for merging.

spanner/client.go Show resolved Hide resolved
spanner/transaction.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM.

@larkee larkee merged commit 88cf097 into master Mar 31, 2021
3 checks passed
@larkee larkee deleted the spanner-rpc-priority branch Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants