Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal): copy pubsub Message and PublishResult to internal/pubsub #3351

Merged
merged 5 commits into from Dec 3, 2020

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Dec 3, 2020

Message and PublishResult will be used by the pubsub and pubsublite packages, which require access to internal fields that should not be made public. The decision was made not to alter the public API of the pubsub package and only allow packages under google-cloud-go to access new functions.

See discussion in the following for background: #3200 and #3231.

@tmdiep tmdiep requested a review from googleapis/yoshi-go-admins as a code owner Dec 3, 2020
@google-cla google-cla bot added the cla: yes label Dec 3, 2020
@codyoss codyoss changed the title internal: copy pubsub Message and PublishResult to internal/pubsub feat(internal): copy pubsub Message and PublishResult to internal/pubsub Dec 3, 2020
@codyoss codyoss requested a review from hongalex Dec 3, 2020
@codyoss
codyoss approved these changes Dec 3, 2020
@tmdiep tmdiep merged commit 82521ee into googleapis:master Dec 3, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@tmdiep tmdiep deleted the tmdiep:internal_pubsub branch Dec 3, 2020
tmdiep added a commit to tmdiep/google-cloud-go that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants