feat(internal): copy pubsub Message and PublishResult to internal/pubsub#3351
Merged
tmdiep merged 5 commits intogoogleapis:masterfrom Dec 3, 2020
Merged
feat(internal): copy pubsub Message and PublishResult to internal/pubsub#3351tmdiep merged 5 commits intogoogleapis:masterfrom
tmdiep merged 5 commits intogoogleapis:masterfrom
Conversation
google-cla
bot
added
the
cla: yes
codyoss
changed the title
This was referenced Dec 3, 2020
hongalex
approved these changes
Dec 3, 2020
codyoss
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessageandPublishResultwill be used by thepubsubandpubsublitepackages, which require access to internal fields that should not be made public. The decision was made not to alter the public API of thepubsubpackage and only allow packages undergoogle-cloud-goto access new functions.See discussion in the following for background: #3200 and #3231.