Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): support NUMERIC data type #3411

Merged
merged 1 commit into from Dec 8, 2020

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Dec 7, 2020

This adds support for NUMERIC as a column data type in CREATE TABLE and
similar constructions. Its support in spannertest remains a TODO.

Fixes #3395.

@dsymonds dsymonds added api: spanner Issues related to the Cloud Spanner API. automerge Merge the pull request once unit tests and other checks pass. labels Dec 7, 2020
@dsymonds dsymonds requested a review from skuruppu Dec 7, 2020
@dsymonds dsymonds requested a review from a team as a code owner Dec 7, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Dec 8, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2020
This adds support for NUMERIC as a column data type in CREATE TABLE and
similar constructions. Its support in spannertest remains a TODO.

Fixes #3395.
@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1bc65d9 into googleapis:master Dec 8, 2020
2 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2020
@dsymonds dsymonds deleted the spansql-numeric branch Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spansql: support for NUMERIC type
2 participants