Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): fix default stream ack deadline seconds #3430

Merged
merged 3 commits into from Dec 9, 2020

Conversation

@hongalex
Copy link
Member

@hongalex hongalex commented Dec 9, 2020

A error was made in #3367 when using the default MaxExtensionPeriod of 0 seconds. This also made the default stream ack deadline seconds 0, which means messages will always expire and messages will never be successfully delivered. This PR reverts to the previous default of 60 seconds if MaxExtensionPeriod is disabled.

This issue fixes #3397, fixes #3398, fixes #3399

@hongalex hongalex requested a review from as a code owner Dec 9, 2020
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
pubsub/pullstream.go Outdated Show resolved Hide resolved
Loading
tmdiep
tmdiep approved these changes Dec 9, 2020
@hongalex hongalex merged commit a10263a into master Dec 9, 2020
3 checks passed
Loading
@hongalex hongalex deleted the fix-stream-ack-deadline branch Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants