Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): subscriber client #3442

Merged
merged 10 commits into from Jan 6, 2021
Merged

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Dec 10, 2020

SubscriberClient wraps Pub/Sub Lite's wire.Subscriber and emulates the pubsub.Subscription.Receive API.

Not mergeable until dependent PRs have been committed to master.

@tmdiep
Copy link
Contributor Author

@tmdiep tmdiep commented Dec 10, 2020

WANT_LGTM=@dpcollins-google for Pub/Sub Lite logic, @hongalex for consistency with CPS. I've tried to replicate most of the documented behavior, e.g. waiting for all receiver funcs to finish before returning from Receive().

@tmdiep tmdiep force-pushed the shim_subscriber branch from 86dd6c2 to a33a81e Dec 23, 2020
Copy link
Member

@hongalex hongalex left a comment

some minor nits

pubsublite/ps/subscriber.go Outdated Show resolved Hide resolved
pubsublite/ps/example_test.go Show resolved Hide resolved
@tmdiep tmdiep merged commit 221bfba into googleapis:master Jan 6, 2021
3 checks passed
@tmdiep tmdiep deleted the shim_subscriber branch Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants