Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): add client library metadata to headers #3458

Merged
merged 6 commits into from Jan 7, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Dec 14, 2020

Adds client library version and other properties to gRPC stream metadata for debugging purposes.

@tmdiep tmdiep requested a review from as a code owner Dec 14, 2020
@google-cla google-cla bot added the cla: yes label Dec 14, 2020
@tmdiep tmdiep requested a review from codyoss Dec 14, 2020
@tmdiep
Copy link
Contributor Author

@tmdiep tmdiep commented Dec 14, 2020

@codyoss: We'd like to send the pubsublite library version to the server for debugging purposes. debug.BuildInfo works well for binaries built with modules, but do you know what options we have if GOPATH is used?

@tmdiep tmdiep force-pushed the pubsub_headers branch from c25ca8b to 69f3ff1 Dec 23, 2020
@tmdiep tmdiep requested a review from hongalex Jan 6, 2021
Copy link
Member

@codyoss codyoss left a comment

Just one small comment or else seems good to me. Only other thing is that I think we need to document these additional headers somewhere(internal). That way things can be consistent across languages and people can tell what the values mean. It is very possible this is already done and I am oblivious though.

pubsublite/internal/wire/rpc.go Show resolved Hide resolved
@tmdiep tmdiep merged commit 8226811 into googleapis:master Jan 7, 2021
3 checks passed
@tmdiep tmdiep deleted the pubsub_headers branch Jan 7, 2021
nicoleczhu pushed a commit to nicoleczhu/google-cloud-go that referenced this issue Jan 8, 2021
…3458)

Adds client library version and other properties to gRPC stream metadata for debugging purposes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants