Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): run E2E test over DirectPath #3466

Merged
merged 4 commits into from Dec 22, 2020

Conversation

mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Dec 15, 2020

Run spanner-go integration tests over directpath traffic.

@mohanli-ml mohanli-ml requested review from skuruppu and a team as code owners Dec 15, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Dec 15, 2020
Copy link
Contributor

@olavloite olavloite left a comment

LGTM, with a non-blocking question on using env vars instead of hard coding the addresses.

spanner/integration_test.go Show resolved Hide resolved
@thiagotnunes thiagotnunes merged commit 18e3a4f into googleapis:master Dec 22, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants