fix(internal/gapicgen): don't regen files that have been deleted#3471
Merged
codyoss merged 4 commits intogoogleapis:masterfrom Jan 5, 2021
codyoss:not-deleted
Merged
fix(internal/gapicgen): don't regen files that have been deleted#3471codyoss merged 4 commits intogoogleapis:masterfrom codyoss:not-deleted
codyoss merged 4 commits intogoogleapis:masterfrom
codyoss:not-deleted
Conversation
Currently this method will find all the files that haven been updated since the last hash. This is then used to find out which packages will need to be regenered. We should not try to regenerate files that have been deleted, this causes a file does not exist error when running the generator. The provided flag restricts to files that: - (A) Added - (C) Copied - (M) Modified - (R) Renamed
google-cla
bot
added
the
cla: yes
codyoss
changed the title
Member
Author
|
@tbpg When you have a chance, could you review this PR. This is currently blocking regens. |
tbpg
approved these changes
Jan 5, 2021
codyoss
added
the
automerge
codyoss
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this method will find all the files that haven been
updated since the last hash. This is then used to find out
which packages will need to be regenered. We should not try to
regenerate files that have been deleted, this causes a file does
not exist error when running the generator.
The provided flag restricts to files that: