Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/gapicgen): don't regen files that have been deleted #3471

Merged
merged 4 commits into from Jan 5, 2021

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Dec 16, 2020

Currently this method will find all the files that haven been
updated since the last hash. This is then used to find out
which packages will need to be regenered. We should not try to
regenerate files that have been deleted, this causes a file does
not exist error when running the generator.

The provided flag restricts to files that:

  • (A) Added
  • (C) Copied
  • (M) Modified
  • (R) Renamed
 Currently this method will find all the files that haven been
 updated since the last hash. This is then used to find out
 which packages will need to be regenered. We should not try to
 regenerate files that have been deleted, this causes a file does
 not exist error when running the generator.

 The provided flag restricts to files that:
   - (A) Added
   - (C) Copied
   - (M) Modified
   - (R) Renamed
@codyoss codyoss requested a review from googleapis/yoshi-go-admins as a code owner Dec 16, 2020
@google-cla google-cla bot added the cla: yes label Dec 16, 2020
@codyoss codyoss changed the title fix(internal/gapicgen): don't regen files that have been deleted fix(internal/gapicgen): don't regen files that have been deleted Jan 5, 2021
@codyoss
Copy link
Member Author

@codyoss codyoss commented Jan 5, 2021

@tbpg When you have a chance, could you review this PR. This is currently blocking regens.

@tbpg
tbpg approved these changes Jan 5, 2021
internal/gapicgen/generator/git.go Show resolved Hide resolved
@codyoss codyoss merged commit 112ca94 into googleapis:master Jan 5, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@codyoss codyoss deleted the codyoss:not-deleted branch Jan 5, 2021
@codyoss codyoss removed the automerge label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants