Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): return an error if no topic or subscription fields were updated #3502

Merged
merged 2 commits into from Jan 7, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jan 6, 2021

Minor change to return an error if UpdateTopic and UpdateSubscription have no fields to update, for consistency with CPS implementation.

@tmdiep tmdiep requested a review from as a code owner Jan 6, 2021
@google-cla google-cla bot added the cla: yes label Jan 6, 2021
@tmdiep tmdiep merged commit a875969 into googleapis:master Jan 7, 2021
3 checks passed
@tmdiep tmdiep deleted the admin_update branch Jan 7, 2021
nicoleczhu pushed a commit to nicoleczhu/google-cloud-go that referenced this issue Jan 8, 2021
…ere updated (googleapis#3502)

For consistency with pubsub implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants