Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add projection parameter for BucketHandle.Objects() #3549

Merged
merged 11 commits into from Jan 22, 2021

Conversation

@ava12
Copy link
Contributor

@ava12 ava12 commented Jan 13, 2021

Closes #3445.

Copy link
Collaborator

@tritone tritone left a comment

Thanks! A few comments...

Loading

storage/storage.go Outdated Show resolved Hide resolved
Loading
storage/storage.go Outdated Show resolved Hide resolved
Loading
storage/storage.go Outdated Show resolved Hide resolved
Loading
storage/storage.go Outdated Show resolved Hide resolved
Loading
storage/bucket_test.go Outdated Show resolved Hide resolved
Loading
@ava12 ava12 requested a review from tritone Jan 15, 2021
Copy link
Collaborator

@tritone tritone left a comment

Looks good! Running gofmt should resolve the presubmit failure.

Loading

storage/storage.go Outdated Show resolved Hide resolved
Loading
@ava12 ava12 requested a review from tritone Jan 15, 2021
@ava12 ava12 requested a review from codyoss Jan 19, 2021
@tritone tritone requested a review from frankyn Jan 21, 2021
Copy link
Collaborator

@tritone tritone left a comment

LGTM. @codyoss @frankyn feel free to chime in if you have thoughts.

Loading

storage/integration_test.go Outdated Show resolved Hide resolved
Loading
@ava12 ava12 requested a review from codyoss Jan 22, 2021
@ava12 ava12 deleted the storage-objects-projection branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants