Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): support DATE and TIMESTAMP literals #3557

Merged

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Jan 13, 2021

This parses a reasonable subset, and renders in a reasonable format.
Future work will be required to support this in spannertest, as well as
correctly supporting the full range of valid layouts.

Fixes #3548.

This parses a reasonable subset, and renders in a reasonable format.
Future work will be required to support this in spannertest, as well as
correctly supporting the full range of valid layouts.

Fixes #3548.
@dsymonds dsymonds added the api: spanner Issues related to the Cloud Spanner API. label Jan 13, 2021
@dsymonds dsymonds requested a review from skuruppu Jan 13, 2021
@dsymonds dsymonds requested a review from a team as a code owner Jan 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2021
@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Jan 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1961930 into googleapis:master Jan 14, 2021
3 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 14, 2021
@dsymonds dsymonds deleted the spansql-date-timestamp-lits branch Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spansql: support DATE and TIMESTAMP literals
2 participants