Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite)!: use raw strings for resource paths (api review) #3559

merged 4 commits into from Jan 14, 2021


Copy link

@tmdiep tmdiep commented Jan 14, 2021

  • Moved resource path structs from types.go to internal/wire/resources.go. Not deleted entirely, as we need to parse the components of the path for some operations.
  • The public API now only accepts raw strings containing full resource paths. Comments for every resource path string specify the required format.
  • The resource path strings are validated before sending requests to the server.
  • Updated docs and examples. Corrected references to the service to "Pub/Sub Lite" (removed Cloud prefix).

AI from API review.

@tmdiep tmdiep requested a review from as a code owner Jan 14, 2021
@google-cla google-cla bot added the cla: yes label Jan 14, 2021
pubsublite/admin.go Show resolved Hide resolved
pubsublite/internal/wire/resources.go Show resolved Hide resolved
@tmdiep tmdiep merged commit c18ed25 into googleapis:master Jan 14, 2021
3 checks passed
@tmdiep tmdiep deleted the resource_paths branch Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants