Skip to content

feat(appengine): start generating apiv1#3561

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:masterfrom
codyoss:ae-v1
Jan 14, 2021
Merged

feat(appengine): start generating apiv1#3561
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:masterfrom
codyoss:ae-v1

Conversation

@codyoss
Copy link
Copy Markdown
Member

@codyoss codyoss commented Jan 14, 2021

No description provided.

@codyoss codyoss requested a review from a team January 14, 2021 15:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 14, 2021
@product-auto-label product-auto-label bot added the api: appengine Issues related to the App Engine Admin API API. label Jan 14, 2021
@codyoss
Copy link
Copy Markdown
Member Author

codyoss commented Jan 14, 2021

Note, this is the first gapic(that I know of) that is being generated with out a grpc service config. This should be fine though as that just means methods don't have any sort of retry settings configured. There seem to be no issues with the generated code.

@tbpg tbpg requested a review from noahdietz January 14, 2021 17:03
noahdietz
noahdietz approved these changes Jan 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @codyoss

@noahdietz
Copy link
Copy Markdown
Contributor

noahdietz commented Jan 14, 2021 

TestMicrogenConfigs
    config_test.go:62: config "cloud.google.com/go/appengine/apiv1" (#103) expected non-empty gRPCServiceConfigPath
--- FAIL: TestMicrogenConfigs (0.00s)

I guess we need to allow this option to be empty in the config test as well.

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jan 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2b6a3b4 into googleapis:master Jan 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 14, 2021
@codyoss codyoss deleted the ae-v1 branch January 14, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees

No one assigned

Labels

api: appengine Issues related to the App Engine Admin API API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codyoss @noahdietz