Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appengine): start generating apiv1 #3561

Merged
merged 3 commits into from Jan 14, 2021
Merged

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Jan 14, 2021

No description provided.

@codyoss codyoss requested a review from googleapis/yoshi-go-admins as a code owner Jan 14, 2021
@google-cla google-cla bot added the cla: yes label Jan 14, 2021
@codyoss
Copy link
Member Author

@codyoss codyoss commented Jan 14, 2021

Note, this is the first gapic(that I know of) that is being generated with out a grpc service config. This should be fine though as that just means methods don't have any sort of retry settings configured. There seem to be no issues with the generated code.

@tbpg tbpg requested a review from noahdietz Jan 14, 2021
Copy link
Contributor

@noahdietz noahdietz left a comment

LGTM thanks @codyoss

@noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Jan 14, 2021

TestMicrogenConfigs
    config_test.go:62: config "cloud.google.com/go/appengine/apiv1" (#103) expected non-empty gRPCServiceConfigPath
--- FAIL: TestMicrogenConfigs (0.00s)

I guess we need to allow this option to be empty in the config test as well.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 2b6a3b4 into googleapis:master Jan 14, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@codyoss codyoss deleted the codyoss:ae-v1 branch Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants