Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(networkconnectivity): initial generation of apiv1alpha1 #3567

Merged
merged 7 commits into from Jan 25, 2021

Conversation

@bcoe
Copy link
Collaborator

@bcoe bcoe commented Jan 15, 2021

Initial generation of network connectivity.

@bcoe bcoe requested a review from googleapis/yoshi-go-admins as a code owner Jan 15, 2021
@google-cla google-cla bot added the cla: yes label Jan 15, 2021
@bcoe bcoe requested a review from codyoss Jan 15, 2021
bcoe and others added 2 commits Jan 15, 2021
Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
@bcoe bcoe requested a review from codyoss Jan 16, 2021
Copy link
Member

@codyoss codyoss left a comment

It looks like genlocal still need to be run again. Doing so will move the generated artifacts to a new folder. You might need to manually delete out the file that were generated in the wrong folder.

@codyoss codyoss changed the title feat(networkconnectivity): initial generation of v1alpha1 feat(networkconnectivity): initial generation of apiv1alpha1 Jan 19, 2021
@bcoe bcoe requested a review from codyoss Jan 25, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM, thanks!

@gcf-merge-on-green gcf-merge-on-green bot merged commit adf489a into master Jan 25, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@gcf-merge-on-green gcf-merge-on-green bot deleted the networkconnectivity branch Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants