Skip to content

feat(logging): add localIP and Cache fields to HTTPRequest conversion from proto#3600

Merged
gcf-merge-on-green[bot] merged 3 commits intomasterfrom
fix3588
Jan 25, 2021
Merged

feat(logging): add localIP and Cache fields to HTTPRequest conversion from proto#3600
gcf-merge-on-green[bot] merged 3 commits intomasterfrom
fix3588

Conversation

@freelerobot
Copy link
Copy Markdown
Contributor

Fix #3588

Changes:

  • Turned integration test back on for logadmin. According to previous comments, this may be flakey so I will closely monitor and debug.
  • Added fields LocalIP, CacheLookup, and CacheFillBytes back to httprequest conversion from proto to logging.httprequest

@freelerobot freelerobot self-assigned this Jan 22, 2021
@freelerobot freelerobot requested review from a team January 22, 2021 23:56
@product-auto-label product-auto-label Bot added the api: logging Issues related to the Cloud Logging API. label Jan 22, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2021
@freelerobot freelerobot added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jan 22, 2021
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freelerobot freelerobot added the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit f93027b into master Jan 25, 2021
@gcf-merge-on-green gcf-merge-on-green Bot deleted the fix3588 branch January 25, 2021 18:56
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logging: missing assignment in function "toHTTPRequest"

2 participants