Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): add localIP and Cache fields to HTTPRequest conversion from proto #3600

Merged
merged 3 commits into from Jan 25, 2021

Conversation

@0xSage
Copy link
Contributor

@0xSage 0xSage commented Jan 22, 2021

Fix #3588

Changes:

  • Turned integration test back on for logadmin. According to previous comments, this may be flakey so I will closely monitor and debug.
  • Added fields LocalIP, CacheLookup, and CacheFillBytes back to httprequest conversion from proto to logging.httprequest
@0xSage 0xSage self-assigned this Jan 22, 2021
@0xSage 0xSage requested review from as code owners Jan 22, 2021
@google-cla google-cla bot added the cla: yes label Jan 22, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

@gcf-merge-on-green gcf-merge-on-green bot merged commit f93027b into master Jan 25, 2021
3 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix3588 branch Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants