Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support PublicAccessPrevention #3608

Merged
merged 13 commits into from Jun 28, 2021
Merged

Conversation

@tritone
Copy link
Collaborator

@tritone tritone commented Jan 25, 2021

This is a new field in the IAM configuration for buckets.
Support viewing/setting via bucket attrs, and add an integration
test for the feature.

Closes #3203

tritone added 3 commits Jan 25, 2021
This is a new field in the IAM configuration for buckets.
Support viewing/setting via bucket attrs, and add an integration
test for the feature.

Closes googleapis#3203
@tritone tritone requested a review from as a code owner Jan 25, 2021
@google-cla google-cla bot added the cla: yes label Jan 25, 2021
@tritone tritone requested review from frankyn and shaffeeullah Jan 25, 2021
Copy link
Member

@shaffeeullah shaffeeullah left a comment

Thanks for implementing this, Chris!!

Loading

// enforces Public Access Prevention on the bucket.
PublicAccessPreventionEnforced

publicAccessPreventionDefault string = ""
Copy link
Member

@shaffeeullah shaffeeullah Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the naming of this field might be confusing. Public Access Prevention defaults to 'unspecified'. It will never hold a blank value. I'm trying to think of another option.

Loading

Copy link
Collaborator Author

@tritone tritone Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on this one-- I was trying to follow https://google.aip.dev/126 but it suggests "unspecified" for a zero value. 😆 Suggestions welcome!

Loading

Copy link
Collaborator Author

@tritone tritone Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went for "unknown" here instead.

Loading

storage/bucket_test.go Show resolved Hide resolved
Loading
storage/bucket_test.go Show resolved Hide resolved
Loading
tritone added a commit to tritone/golang-samples that referenced this issue Jan 26, 2021
Adds samples for 3 new region tags for PublicAccessPrevention
feature. See library PR at googleapis/google-cloud-go#3608
storage/integration_test.go Outdated Show resolved Hide resolved
Loading
@tritone tritone requested a review from Mar 22, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

Loading

@shaffeeullah
Copy link
Member

@shaffeeullah shaffeeullah commented Jun 8, 2021

@tritone ,

We would like to merge and release this feature next Monday (06/14/21). Does that work for you?

Loading

@shaffeeullah
Copy link
Member

@shaffeeullah shaffeeullah commented Jun 11, 2021

Public access prevention rollout has been delayed due to a bug surfaced during Googler preview. I will keep this PR updated as I learn new release timeline details.

Loading

@shaffeeullah
Copy link
Member

@shaffeeullah shaffeeullah commented Jun 28, 2021

@tritone This feature can now be merged and released.

Loading

@tritone tritone merged commit 99bc782 into googleapis:master Jun 28, 2021
5 checks passed
Loading
@tritone tritone deleted the bucket-pap branch Jun 28, 2021
codyoss pushed a commit to GoogleCloudPlatform/golang-samples that referenced this issue Jun 30, 2021
Adds samples for 3 new region tags for PublicAccessPrevention
feature. See library PR at googleapis/google-cloud-go#3608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants