Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/godocfx): xref function declarations #3615

Merged
merged 2 commits into from Jan 27, 2021
Merged

Conversation

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Jan 26, 2021

Type declarations are handled differently. So, I'll handle them in a
future PR. There are some TODOs at the top of parse.go with additional
ways we can improve.

I chose to define linkify in parse.go rather than pkgsite because (1) we
need the package/import name logic and (2) I want to keep changes to a
minimum in the third_party code.

Type declarations are handled differently. So, I'll handle them in a
future PR. There are some TODOs at the top of parse.go with additional
ways we can improve.

I chose to define linkify in parse.go rather than pkgsite because (1) we
need the package/import name logic and (2) I want to keep changes to a
minimum in the third_party code.
@tbpg tbpg requested a review from codyoss Jan 26, 2021
@tbpg tbpg requested a review from googleapis/yoshi-go-admins as a code owner Jan 26, 2021
@google-cla google-cla bot added the cla: yes label Jan 26, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

@tbpg tbpg added the automerge label Jan 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2bdbb87 into master Jan 27, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@gcf-merge-on-green gcf-merge-on-green bot deleted the godocfx branch Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants