feat(internal/godocfx): xref function declarations#3615
Merged
gcf-merge-on-green[bot] merged 2 commits intomasterfrom Jan 27, 2021
Merged
feat(internal/godocfx): xref function declarations#3615gcf-merge-on-green[bot] merged 2 commits intomasterfrom
gcf-merge-on-green[bot] merged 2 commits intomasterfrom
Conversation
Type declarations are handled differently. So, I'll handle them in a future PR. There are some TODOs at the top of parse.go with additional ways we can improve. I chose to define linkify in parse.go rather than pkgsite because (1) we need the package/import name logic and (2) I want to keep changes to a minimum in the third_party code.
google-cla
bot
added
the
cla: yes
tbpg
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type declarations are handled differently. So, I'll handle them in a
future PR. There are some TODOs at the top of parse.go with additional
ways we can improve.
I chose to define linkify in parse.go rather than pkgsite because (1) we
need the package/import name logic and (2) I want to keep changes to a
minimum in the third_party code.