Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spannertest): restructure column alteration implementation #3616

Merged
merged 1 commit into from Jan 27, 2021

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Jan 26, 2021

Separate out validation from the alteration so that validation failures
won't leave a corrupted table. This will also permit other schema
changes to be more easily added in the future.

Permit adding and removing NOT NULL for column types other than
string/bytes, and enforce that it isn't permitted on primary key columns
or array-typed columns.

Separate out validation from the alteration so that validation failures
won't leave a corrupted table. This will also permit other schema
changes to be more easily added in the future.

Permit adding and removing NOT NULL for column types other than
string/bytes, and enforce that it isn't permitted on primary key columns
or array-typed columns.
@dsymonds dsymonds added the api: spanner Issues related to the Cloud Spanner API. label Jan 26, 2021
@dsymonds dsymonds requested a review from skuruppu Jan 26, 2021
@dsymonds dsymonds requested a review from a team as a code owner Jan 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@dsymonds dsymonds merged commit 176400b into googleapis:master Jan 27, 2021
3 checks passed
@dsymonds dsymonds deleted the spannertest-alter branch Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants