Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): address a missing branch in watch.stop() error remapping #3643

Merged
merged 4 commits into from Feb 2, 2021

Conversation

@crwilcox
Copy link
Collaborator

@crwilcox crwilcox commented Feb 1, 2021

While debugging another issue, I came across what appears to be a missing branch

@crwilcox crwilcox requested a review from jba Feb 1, 2021
@crwilcox crwilcox requested review from tritone and as code owners Feb 1, 2021
@google-cla google-cla bot added the cla: yes label Feb 1, 2021
tritone
tritone approved these changes Feb 1, 2021
s.err = err
} else {
Copy link
Member

@codyoss codyoss Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, prefer not including else blocks: https://golang.org/doc/effective_go.html#if

Loading

Copy link
Collaborator Author

@crwilcox crwilcox Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to make this a return. I am going to wait for @jba to maybe weigh in. Since this is either code that should have been removed, or this branch was missed :)

Loading

@jba
Copy link
Contributor

@jba jba commented Feb 1, 2021

Wow, that is definitely a bug. Thanks for catching. LGTM.

Loading

@crwilcox crwilcox merged commit 89ad55d into googleapis:master Feb 2, 2021
3 checks passed
Loading
@crwilcox crwilcox deleted the fix-branch branch Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants