Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): allow increasing the number of topic partitions #3647

Merged
merged 3 commits into from Feb 18, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Feb 2, 2021

Allows increasing the number of partitions when updating a topic config. Updates documentation, examples and integration tests.

Will not be merged until server changes have been fully rolled out.

@@ -189,6 +189,7 @@ func TestIntegration_ResourceAdminOperations(t *testing.T) {

topicUpdate1 := TopicConfigToUpdate{
Name: topicPath,
PartitionCount: 2,
Copy link
Member

@hongalex hongalex Feb 17, 2021

What happens when a PartitionCount doesn't change? Will the server throw an error here?

Copy link
Contributor Author

@tmdiep tmdiep Feb 17, 2021

Good question. I just tried it and it's a no-op.

@tmdiep tmdiep merged commit 1f85fdc into googleapis:master Feb 18, 2021
4 checks passed
@tmdiep tmdiep deleted the increase_partitions branch Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants