Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/docfx): full cross reference linking #3656

Merged
merged 3 commits into from
Feb 2, 2021
Merged

feat(internal/docfx): full cross reference linking #3656

merged 3 commits into from
Feb 2, 2021

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Feb 2, 2021

The changes to pkgsite are mostly copied and pasted. I modified it a little to make the API easier to use. I also added the explanatory comment at the top of PrintType because it took a while for me to wrap my head around it.

@tbpg tbpg requested a review from codyoss February 2, 2021 19:54
@tbpg tbpg requested a review from a team as a code owner February 2, 2021 19:54
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg merged commit fcb7318 into master Feb 2, 2021
@tbpg tbpg deleted the godocfx branch February 2, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants