Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/docfx): full cross reference linking #3656

Merged
merged 3 commits into from Feb 2, 2021
Merged

feat(internal/docfx): full cross reference linking #3656

merged 3 commits into from Feb 2, 2021

Conversation

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Feb 2, 2021

The changes to pkgsite are mostly copied and pasted. I modified it a little to make the API easier to use. I also added the explanatory comment at the top of PrintType because it took a while for me to wrap my head around it.

@tbpg tbpg requested a review from codyoss Feb 2, 2021
@tbpg tbpg requested a review from googleapis/yoshi-go-admins as a code owner Feb 2, 2021
@google-cla google-cla bot added the cla: yes label Feb 2, 2021
@codyoss
codyoss approved these changes Feb 2, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

@tbpg tbpg merged commit fcb7318 into master Feb 2, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@tbpg tbpg deleted the godocfx branch Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants