Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/godocfx): use exact list of top-level decls #3665

Merged
merged 1 commit into from Feb 3, 2021
Merged

fix(internal/godocfx): use exact list of top-level decls #3665

merged 1 commit into from Feb 3, 2021

Conversation

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Feb 3, 2021

Here is a resulting diff from the firestore package:

-    content: var MergeAll <a href="#setoption">SetOption</a> = <a href="#merge">merge</a>{/*
-      contains filtered or unexported fields */}
+    content: var MergeAll <a href="#setoption">SetOption</a> = merge{/* contains filtered
+      or unexported fields */}

Note that merge should not be linked. This PR fixes that.

@tbpg tbpg requested a review from codyoss Feb 3, 2021
@tbpg tbpg requested a review from googleapis/yoshi-go-admins as a code owner Feb 3, 2021
@google-cla google-cla bot added the cla: yes label Feb 3, 2021
@codyoss
codyoss approved these changes Feb 3, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

@tbpg tbpg merged commit 3cd2961 into master Feb 3, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@tbpg tbpg deleted the godocfx branch Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants