Skip to content

fix(internal/godocfx): use exact list of top-level decls#3665

Merged
tbpg merged 1 commit intomasterfrom
godocfx
Feb 3, 2021
Merged

fix(internal/godocfx): use exact list of top-level decls#3665
tbpg merged 1 commit intomasterfrom
godocfx

Conversation

@tbpg
Copy link
Copy Markdown
Contributor

@tbpg tbpg commented Feb 3, 2021

Here is a resulting diff from the firestore package:

-    content: var MergeAll <a href="#setoption">SetOption</a> = <a href="#merge">merge</a>{/*
-      contains filtered or unexported fields */}
+    content: var MergeAll <a href="#setoption">SetOption</a> = merge{/* contains filtered
+      or unexported fields */}

Note that merge should not be linked. This PR fixes that.

@tbpg tbpg requested review from a team and codyoss February 3, 2021 15:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2021
@tbpg tbpg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2021
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg merged commit 3cd2961 into master Feb 3, 2021
@tbpg tbpg deleted the godocfx branch February 3, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants