Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/godocfx): use exact list of top-level decls #3665

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Feb 3, 2021

Here is a resulting diff from the firestore package:

-    content: var MergeAll <a href="#setoption">SetOption</a> = <a href="#merge">merge</a>{/*
-      contains filtered or unexported fields */}
+    content: var MergeAll <a href="#setoption">SetOption</a> = merge{/* contains filtered
+      or unexported fields */}

Note that merge should not be linked. This PR fixes that.

@tbpg tbpg requested a review from codyoss February 3, 2021 15:46
@tbpg tbpg requested a review from a team as a code owner February 3, 2021 15:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2021
@tbpg tbpg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg merged commit 3cd2961 into master Feb 3, 2021
@tbpg tbpg deleted the godocfx branch February 3, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants