Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): parallelize session deletion when closing pool #3701

Merged
merged 4 commits into from Feb 16, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Feb 12, 2021

Closing the session pool when closing a Spanner client should be quick and should ignore any errors that are caused by an unresponsive backend or by loss of connectivity. Go does not support fire-and-forget RPC invocations. Instead this solution uses parallel invocations of the DeleteSession RPC with short timeouts that are ignored if they occur.

Fixes #3685

olavloite added 2 commits Feb 12, 2021
Closing the session pool when closing a Spanner client should be quick and
should ignore any errors that are caused by an unresponsive backend or by
loss of connectivity. Go does not support fire-and-forget RPC invocations.
Instead this solution uses parallel invocations of the DeleteSession RPC
with short timeouts that are ignored if they occur.

Fixes #3685
@olavloite olavloite requested a review from skuruppu Feb 12, 2021
@olavloite olavloite requested a review from a team as a code owner Feb 12, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Feb 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2021
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Feb 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 75ac7d2 into master Feb 16, 2021
3 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the issue-3685 branch Feb 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 16, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: session pool destruction with disconnected client
2 participants