Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spansql): fix parsing of NOT IN operator #3724

Merged
merged 1 commit into from Feb 24, 2021

Conversation

@dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Feb 22, 2021

The parsing of comparison operators was erroneously capturing any NOT
token assuming it would be followed by a LIKE or BETWEEN. Instead,
change that code to explicitly look ahead for the limited combinations
allowed, and do the same for parsing IN and NOT IN.

Fixes #3715.

@dsymonds
Copy link
Contributor Author

@dsymonds dsymonds commented Feb 22, 2021

/cc @sryoya

Loading

@dsymonds
Copy link
Contributor Author

@dsymonds dsymonds commented Feb 23, 2021

Thanks, can you submit @skuruppu? I no longer have access to do that.

Loading

@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Feb 24, 2021

@dsymonds for some reason, I'm not able to click a button to update the branch to pick up latest changes from main.

Loading

The parsing of comparison operators was erroneously capturing any NOT
token assuming it would be followed by a LIKE or BETWEEN. Instead,
change that code to explicitly look ahead for the limited combinations
allowed, and do the same for parsing IN and NOT IN.

Fixes googleapis#3715.
@dsymonds
Copy link
Contributor Author

@dsymonds dsymonds commented Feb 24, 2021

Okay, manually rebased. Try again please.

Loading

@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Feb 24, 2021

Seems good. Now waiting for Kokoro to run.

Loading

@gcf-merge-on-green gcf-merge-on-green bot merged commit 7636478 into googleapis:master Feb 24, 2021
3 checks passed
Loading
@dsymonds dsymonds deleted the spansql-not-in branch Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants