Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spansql): fix parsing of NOT IN operator #3724

Merged
merged 1 commit into from Feb 24, 2021

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Feb 22, 2021

The parsing of comparison operators was erroneously capturing any NOT
token assuming it would be followed by a LIKE or BETWEEN. Instead,
change that code to explicitly look ahead for the limited combinations
allowed, and do the same for parsing IN and NOT IN.

Fixes #3715.

@dsymonds dsymonds requested review from skuruppu and a team as code owners Feb 22, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Feb 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2021
@dsymonds
Copy link
Contributor Author

dsymonds commented Feb 22, 2021

/cc @sryoya

@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2021
@dsymonds
Copy link
Contributor Author

dsymonds commented Feb 23, 2021

Thanks, can you submit @skuruppu? I no longer have access to do that.

@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2021
@skuruppu
Copy link
Contributor

skuruppu commented Feb 24, 2021

@dsymonds for some reason, I'm not able to click a button to update the branch to pick up latest changes from main.

The parsing of comparison operators was erroneously capturing any NOT
token assuming it would be followed by a LIKE or BETWEEN. Instead,
change that code to explicitly look ahead for the limited combinations
allowed, and do the same for parsing IN and NOT IN.

Fixes #3715.
@dsymonds
Copy link
Contributor Author

dsymonds commented Feb 24, 2021

Okay, manually rebased. Try again please.

@skuruppu
Copy link
Contributor

skuruppu commented Feb 24, 2021

Seems good. Now waiting for Kokoro to run.

@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2021
@skuruppu skuruppu added the automerge Merge the pull request once unit tests and other checks pass. label Feb 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7636478 into googleapis:master Feb 24, 2021
3 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 24, 2021
@dsymonds dsymonds deleted the spansql-not-in branch Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spannertest/spansql: Support "NOT IN" clause
3 participants