Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): update quiescenceDur in failing e2e test #3780

Merged
merged 2 commits into from Mar 8, 2021

Conversation

@hongalex
Copy link
Member

@hongalex hongalex commented Mar 8, 2021

TestEndToEnd_LongProcessingTime used to depend on a grpc cancelled error to finish before the 15 second test timer expires. After #3752, we hide these cancelled errors in synchronous pull to be consistent with streaming pull.

Since no fatal error was being thrown, the Receive call gets stuck as we stop processing after the default 60 seconds. Increase this to 120 seconds (or 12 * ackDeadline), which is the upper bound of processing times so all messages received are eventually acked and doesn't block the Receive call. Also, decrease the number of messages published so we only have one batch received. This could have been left as-is, but we would increase the total time the test takes, and is unnecessary to what the test was trying to accomplish.

Fixes #3773

codyoss
codyoss approved these changes Mar 8, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

Loading

@hongalex hongalex merged commit 97e6c69 into googleapis:master Mar 8, 2021
3 checks passed
Loading
@hongalex hongalex deleted the longprocess branch Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants