Skip to content

feat(internal/godocfx): add prettyprint class to code blocks#3819

Merged
gcf-merge-on-green[bot] merged 3 commits intomasterfrom
markdown
Mar 16, 2021
Merged

feat(internal/godocfx): add prettyprint class to code blocks#3819
gcf-merge-on-green[bot] merged 3 commits intomasterfrom
markdown

Conversation

@tbpg
Copy link
Copy Markdown
Contributor

@tbpg tbpg commented Mar 15, 2021

Fixes #3804.

@tbpg tbpg added the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2021
@tbpg tbpg requested review from a team and codyoss March 15, 2021 19:04
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2021
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.


func (r *codeBlockHTMLRenderer) renderCodeBlock(w util.BufWriter, source []byte, n ast.Node, entering bool) (ast.WalkStatus, error) {
if entering {
_, _ = w.WriteString(`<pre><code class="prettyprint">`)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the errors for this write method be returned?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

@codyoss codyoss removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal/godocfx: better styling of package doc

2 participants