Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/godocfx): add prettyprint class to code blocks #3819

merged 3 commits into from Mar 16, 2021


Copy link

@tbpg tbpg commented Mar 15, 2021

Fixes #3804.

@tbpg tbpg added the automerge label Mar 15, 2021
@tbpg tbpg requested a review from codyoss Mar 15, 2021
@tbpg tbpg requested a review from googleapis/yoshi-go-admins as a code owner Mar 15, 2021
@google-cla google-cla bot added the cla: yes label Mar 15, 2021
Copy link

@codyoss codyoss left a comment

LGTM, just one question.

func (r *codeBlockHTMLRenderer) renderCodeBlock(w util.BufWriter, source []byte, n ast.Node, entering bool) (ast.WalkStatus, error) {
if entering {
_, _ = w.WriteString(`<pre><code class="prettyprint">`)

This comment has been minimized.


codyoss Mar 15, 2021

Should the errors for this write method be returned?

This comment has been minimized.


tbpg Mar 16, 2021
Author Collaborator

Done. Thanks!

@codyoss codyoss removed the automerge label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants