Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): ackTracker should discard new acks after committer terminates #3827

Merged
merged 2 commits into from Mar 18, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Mar 17, 2021

When the committer terminates, outstanding acks are ignored by clearing the ackTracker. We should also prevent new acks from being added to ackTracker afterward, which can occur due to races, as they are added elsewhere in subscribeStream.

@tmdiep tmdiep merged commit bc49753 into googleapis:master Mar 18, 2021
3 checks passed
@tmdiep tmdiep deleted the acktracker_release branch Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants