Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialogflow/cx): start generating apiv3 #3850

Merged
merged 3 commits into from Mar 23, 2021
Merged

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Mar 23, 2021

Fixes: #3634

@codyoss codyoss requested a review from tbpg Mar 23, 2021
@codyoss codyoss requested a review from googleapis/yoshi-go-admins as a code owner Mar 23, 2021
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
Copy link
Collaborator

@tbpg tbpg left a comment

Looks like Kokoro is failing, but it seems unrelated?

@codyoss
Copy link
Member Author

@codyoss codyoss commented Mar 23, 2021

@tbpg Should be fixed now, I must have had a dirty workspace from some other testing I was doing.

@codyoss codyoss requested a review from tbpg Mar 23, 2021
@tbpg
tbpg approved these changes Mar 23, 2021
@@ -570,6 +570,15 @@ var microgenGapicConfigs = []*microgenConfig{
apiServiceConfigPath: "google/cloud/dialogflow/cx/v3beta1/dialogflow_v3beta1.yaml",
releaseLevel: "beta",
},
{
inputDirectoryPath: "google/cloud/dialogflow/cx/v3",
pkg: "cx",

This comment has been minimized.

@tbpg

tbpg Mar 23, 2021
Collaborator

This is a not-great package name. But, too late for that. :)

@codyoss codyoss merged commit febbdcf into googleapis:master Mar 23, 2021
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants