Conversation
This tool renderes all examples in the current directory to standalone files. I confirmed this successfully processes every example in this repo. Once I added a go.mod/go.sum in the generated directory, all of the examples passed go vet. A future change will integrate this tool into our automatic generation pipelines and add region tags.
google-cla
Bot
added
the
cla: yes
codyoss
approved these changes
Apr 13, 2021
Member
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
Overall LGTM, just a couple small things.
tbpg
commented
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tool renders all examples in the current directory to standalone
files.
I confirmed this successfully processes every example in this repo. Once
I added a go.mod/go.sum in the generated directory, all of the examples
passed go vet.
A future change will integrate this tool into our automatic generation
pipelines and add region tags.