Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/gensnippets): initial commit #3922

Merged
merged 2 commits into from Apr 13, 2021
Merged

feat(internal/gensnippets): initial commit #3922

merged 2 commits into from Apr 13, 2021

Conversation

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Apr 13, 2021

This tool renders all examples in the current directory to standalone
files.

I confirmed this successfully processes every example in this repo. Once
I added a go.mod/go.sum in the generated directory, all of the examples
passed go vet.

A future change will integrate this tool into our automatic generation
pipelines and add region tags.

This tool renderes all examples in the current directory to standalone
files.

I confirmed this successfully processes every example in this repo. Once
I added a go.mod/go.sum in the generated directory, all of the examples
passed go vet.

A future change will integrate this tool into our automatic generation
pipelines and add region tags.
@tbpg tbpg requested review from codyoss and noahdietz Apr 13, 2021
@tbpg tbpg requested a review from as a code owner Apr 13, 2021
@google-cla google-cla bot added the cla: yes label Apr 13, 2021
Copy link
Member

@codyoss codyoss left a comment

Overall LGTM, just a couple small things.

Loading

internal/gensnippets/main.go Outdated Show resolved Hide resolved
Loading
internal/gensnippets/main.go Outdated Show resolved Hide resolved
Loading
internal/gensnippets/main.go Show resolved Hide resolved
Loading
internal/gensnippets/main.go Show resolved Hide resolved
Loading
Copy link
Collaborator Author

@tbpg tbpg left a comment

Thanks!

Loading

internal/gensnippets/main.go Show resolved Hide resolved
Loading
internal/gensnippets/main.go Outdated Show resolved Hide resolved
Loading
internal/gensnippets/main.go Outdated Show resolved Hide resolved
Loading
internal/gensnippets/main.go Show resolved Hide resolved
Loading
Copy link
Contributor

@noahdietz noahdietz left a comment

lgtm

Loading

@tbpg tbpg merged commit 3fabef0 into master Apr 13, 2021
3 checks passed
Loading
@tbpg tbpg deleted the gensnippets branch Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants