Conversation
I created a new package to make it easier to run than calling the binary. I included a binary for local development. I needed to install `build-base` in the Docker image to get `gcc`, which was needed to `Load` all packages. I modified `gapics.go` to replace `genproto` in every `go.mod` because the changes need to be visible everywhere to `Load` every module.
google-cla
Bot
added
the
cla: yes
|
Here is the summary of possible violations 😱 DetailsThere is a possible violation for not having product prefix.The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 1 region tag.You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
codyoss
reviewed
Apr 15, 2021
Member
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
Just a couple of small things or else looks good. Thanks for some of the cleanup you did as well!
| func (g *GapicGenerator) addModReplaceGenproto() error { | ||
| log.Println("adding temporary genproto replace statement") | ||
| func (g *GapicGenerator) addModReplaceGenproto(dir string) error { | ||
| log.Printf("[%s] adding temporary genproto replace statement\n", dir) |
Member
There was a problem hiding this comment.
nit: same as above about newline.
noahdietz
reviewed
Apr 15, 2021
Contributor
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
LGTM ill let Cody approve
tbpg
commented
Apr 16, 2021
| func (g *GapicGenerator) addModReplaceGenproto() error { | ||
| log.Println("adding temporary genproto replace statement") | ||
| func (g *GapicGenerator) addModReplaceGenproto(dir string) error { | ||
| log.Printf("[%s] adding temporary genproto replace statement\n", dir) |
tbpg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a new package to make it easier to run than calling the binary. I included a binary for local development.
I needed to install
build-basein the Docker image to getgcc, which was needed toLoadall packages.I modified
gapics.goto replacegenprotoin everygo.modbecause the changes need to be visible everywhere toLoadevery module.I ran the generator locally and it seems to work. I only included one directory in this PR because there are a lot of files. I can upload the rest in this PR after initial review.
Updates #3916.