feat(internal): generate region tags for snippets#3962
Merged
Conversation
I found a couple "manual" clients that needed repo-metadata entries, so I added them and included the updated JSON. There are many packages where it doesn't make sense to generate snippets with any sort of correct region tag. So, I just skipped them. We can come back if needed.
google-cla
bot
added
the
cla: yes
|
Here is the summary of possible violations 😱 DetailsThere is a possible violation for not having product prefix.The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 9 region tags.
You are about to delete 1 region tag.This comment is generated by snippet-bot.
|
codyoss
approved these changes
Apr 20, 2021
Member
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
LGTM, thanks for filing in the extra configs!
tbpg
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a couple "manual" clients that needed repo-metadata entries, so
I added them and included the updated JSON.
There are many packages where it doesn't make sense to generate snippets
with any sort of correct region tag. So, I just skipped them. We can
come back if needed.
The region tags end up slightly repetitive (e.g.
accessapproval_generated_accessapproval_apiv1_Client_UpdateAccessApprovalSettings),but I think they're more predictable as-is because the package path may not
always line up with the API shortname.
More in depth configuration of the region tag would probably make things
considerably more complex (need to associate every example with the underlying
RPC?)
cc @amanda-tarafa