Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal): generate region tags for snippets #3962

Merged
merged 3 commits into from Apr 20, 2021
Merged

feat(internal): generate region tags for snippets #3962

merged 3 commits into from Apr 20, 2021

Conversation

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Apr 19, 2021

I found a couple "manual" clients that needed repo-metadata entries, so
I added them and included the updated JSON.

There are many packages where it doesn't make sense to generate snippets
with any sort of correct region tag. So, I just skipped them. We can
come back if needed.

The region tags end up slightly repetitive (e.g.
accessapproval_generated_accessapproval_apiv1_Client_UpdateAccessApprovalSettings),
but I think they're more predictable as-is because the package path may not
always line up with the API shortname.

More in depth configuration of the region tag would probably make things
considerably more complex (need to associate every example with the underlying
RPC?)

cc @amanda-tarafa

I found a couple "manual" clients that needed repo-metadata entries, so
I added them and included the updated JSON.

There are many packages where it doesn't make sense to generate snippets
with any sort of correct region tag. So, I just skipped them. We can
come back if needed.
@tbpg tbpg requested a review from codyoss Apr 19, 2021
@tbpg tbpg requested a review from as a code owner Apr 19, 2021
@google-cla google-cla bot added the cla: yes label Apr 19, 2021
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Apr 19, 2021

Here is the summary of possible violations 😱

There is a possible violation for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 9 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Loading

Copy link
Member

@codyoss codyoss left a comment

LGTM, thanks for filing in the extra configs!

Loading

@tbpg tbpg added the automerge label Apr 20, 2021
@tbpg tbpg merged commit ef2b90e into master Apr 20, 2021
4 checks passed
Loading
@tbpg tbpg deleted the region-tags branch Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants