Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): make config call permission error in Receive transparent #3985

Merged
merged 8 commits into from Apr 23, 2021

Conversation

@hongalex
Copy link
Member

@hongalex hongalex commented Apr 21, 2021

In #3886, a Subscription.Config() call was added to check for EnableMessageOrdering on the subscription before delivering messages with ordering keys in order. This negatively affected users who didn't have the roles/viewer or roles/pubsub.viewer roles on their service account.

This PR incorporates two changes:

  1. The call to Config() is only done (once) when we detect an ordering key in a received message.
  2. If the config call fails, we will deliver messages with ordering keys in order by default.

Fixes #3947

fix(pubsub): make config call permission error in Receive transparent

remove extra whitespace

clarify doc comments

fix typos

fix formatting
@hongalex hongalex force-pushed the pubsub-config-call-check branch from f309ba7 to adad575 Apr 22, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

Loading

@hongalex hongalex requested a review from kamalaboulhosn Apr 22, 2021
@hongalex hongalex merged commit a1614db into googleapis:master Apr 23, 2021
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants