Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): fix failing message storage policy tests #4003

Merged
merged 2 commits into from Apr 23, 2021

Conversation

@hongalex
Copy link
Member

@hongalex hongalex commented Apr 23, 2021

Due to new internal org level policies, we don't have a consistent set of initial message storage policy regions. This PR refactors tests to make them not dependent on any initial region set.

In addition, cleans up the update labels test by removing the check for the unrelated message storage policy field.

Fixes #3065

@google-cla google-cla bot added the cla: yes label Apr 23, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

Loading

@hongalex hongalex merged commit 8946158 into googleapis:master Apr 23, 2021
3 checks passed
Loading
@hongalex hongalex deleted the pubsub-msp branch Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants