Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/gapicgen): add regen-only flag #4015

Merged
merged 3 commits into from Apr 29, 2021

Conversation

noahdietz
Copy link
Contributor

Adds a regen-only flag to local mode that disables generation version updates, manifest updates, and vetting/compilation. This is useful for iterating on generator changes or just fiddling.

This also makes gensnippets respect the only-gapics flag, disabling snippet regen when that flag is enabled.

Finally, it optionally supplies the release-level option to the generator depending on if it is empty or not in the microgenConfig, and uses the flag name api-service-config instead of gapic-service-config, because that is the more accurate name.

@noahdietz noahdietz requested a review from a team as a code owner April 27, 2021 21:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Apr 28, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2021
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2021
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 022fc35 into googleapis:master Apr 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants