Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/gapicgen): use correct region tags for gensnippets #4022

Merged
merged 3 commits into from Apr 29, 2021

Conversation

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Apr 29, 2021

A side effect of this is that only methods that correspond to RPCs get
region tags.

I changed the error handling so any snippet issues are only warnings and
don't log.Fatal (cc @noahdietz).

I deleted and regenerated all of the snippets, which led to non-Method
snippets (e.g. NewClient-type functions) being deleted.

The first commit has the actual generator changes. The second commit is
the regeneration.

cc @amanda-tarafa.

tbpg added 2 commits Apr 29, 2021
A side effect of this is that only methods that correspond to RPCs get
region tags.

I changed the error handling so any snippet issues are only warnings and
don't log.Fatal.

I deleted and regenerated all of the snippets, which led to non-Method
snippets (e.g. NewClient) being deleted.
@tbpg tbpg requested review from codyoss and noahdietz Apr 29, 2021
@tbpg tbpg requested a review from as a code owner Apr 29, 2021
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

Loading

@tbpg tbpg added the automerge label Apr 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8ccd689 into master Apr 29, 2021
4 checks passed
Loading
@gcf-merge-on-green gcf-merge-on-green bot deleted the gensnippets branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants