fix(internal/gapicgen): use correct region tags for gensnippets #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A side effect of this is that only methods that correspond to RPCs get region tags. I changed the error handling so any snippet issues are only warnings and don't log.Fatal. I deleted and regenerated all of the snippets, which led to non-Method snippets (e.g. NewClient) being deleted.
google-cla
bot
added
the
cla: yes
tbpg
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side effect of this is that only methods that correspond to RPCs get
region tags.
I changed the error handling so any snippet issues are only warnings and
don't
log.Fatal(cc @noahdietz).I deleted and regenerated all of the snippets, which led to non-Method
snippets (e.g.
NewClient-type functions) being deleted.The first commit has the actual generator changes. The second commit is
the regeneration.
cc @amanda-tarafa.