Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): case insensitive parsing of keywords and functions #4034

Merged
merged 1 commit into from May 4, 2021

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented May 3, 2021

This handles the most important parts of the parser as it relates to
case insensitivity, namely permitting the lexical tokens for the grammar
(as opposed to elements like table/column names) to have arbitrary case.

This includes a complete audit of the parser to check all the lexical
token handling, and cleaned up a few places that were particularly
ancient.

The rendered output remains canonically uppercase.

Fixes #4032.

@dsymonds dsymonds requested review from hengfengli, skuruppu and a team as code owners May 3, 2021
@google-cla
Copy link

google-cla bot commented May 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label May 3, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label May 3, 2021
@dsymonds
Copy link
Contributor Author

dsymonds commented May 3, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 3, 2021
@dsymonds
Copy link
Contributor Author

dsymonds commented May 3, 2021

@olavloite

@hengfengli hengfengli requested a review from olavloite May 3, 2021
Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM.

@hengfengli
Copy link
Contributor

hengfengli commented May 3, 2021

@dsymonds Can you please rebase this branch? Thanks.

@dsymonds dsymonds force-pushed the spansql-case-insensitivity branch from 03472ac to f9c9209 Compare May 3, 2021
@dsymonds
Copy link
Contributor Author

dsymonds commented May 3, 2021

Rebased!

@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2021
@hengfengli
Copy link
Contributor

hengfengli commented May 3, 2021

Missed the chance to merge again, :-(. I will try to rebase it if I can.

@hengfengli
Copy link
Contributor

hengfengli commented May 4, 2021

I don't see a button on this PR to allow me to rebase it. Also, I tried to bring the PR to local and rebase it. But when I push it, it gets rejected. @dsymonds can you please rebase it again? sorry for the trouble.

…ions

This handles the most important parts of the parser as it relates to
case insensitivity, namely permitting the lexical tokens for the grammar
(as opposed to elements like table/column names) to have arbitrary case.

This includes a complete audit of the parser to check all the lexical
token handling, and cleaned up a few places that were particularly
ancient.

The rendered output remains canonically uppercase.

Fixes #4032.
@dsymonds dsymonds force-pushed the spansql-case-insensitivity branch from f9c9209 to 8c5a00d Compare May 4, 2021
@dsymonds
Copy link
Contributor Author

dsymonds commented May 4, 2021

rebased, @hengfengli

@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2021
@hengfengli hengfengli merged commit ddb09d2 into googleapis:master May 4, 2021
3 checks passed
@dsymonds dsymonds deleted the spansql-case-insensitivity branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spansql: Make spansql case-insensitive
4 participants