Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): prevent subscriber flow control token races #4060

Merged
merged 4 commits into from May 5, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented May 5, 2021

Ensure that we send flowControlBatcher.RequestForRestart immediately after a new Subscribe stream is connected, before any batched flow control tokens are sent.

This hasn't been detected by tests or observed, but theoretically can occur via onAckAsync().

@tmdiep tmdiep force-pushed the batch_flow_control branch from 233c54d to f17a2ba May 5, 2021
@tmdiep tmdiep merged commit dc0103b into googleapis:master May 5, 2021
3 checks passed
@tmdiep tmdiep deleted the batch_flow_control branch May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants