Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/gapicgen): only update relevant gapic files #4066

merged 5 commits into from May 10, 2021


Copy link

@codyoss codyoss commented May 6, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label May 6, 2021
Copy link

@snippet-bot snippet-bot bot commented May 6, 2021

Here is the summary of changes.

You are about to add 41 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment


@codyoss codyoss marked this pull request as ready for review May 7, 2021
@codyoss codyoss requested a review from as a code owner May 7, 2021
Copy link
Member Author

@codyoss codyoss commented May 7, 2021

Sample generation using this code:

Note that in the gapic PR there are far fewer diffs now. This will help create less noise for release PRs. Instead of regen triggering a release PR to update, now they will only update if their are relevant changes.


@codyoss codyoss requested a review from tbpg May 7, 2021
tbpg approved these changes May 10, 2021
internal/gapicgen/git/git.go Outdated Show resolved Hide resolved
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5948bee into master May 10, 2021
3 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the filter-update branch May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants