fix(internal/gapicgen): filter out internal directory changes#4085
Merged
codyoss merged 3 commits intogoogleapis:masterfrom May 12, 2021
codyoss:filter-internal
Merged
fix(internal/gapicgen): filter out internal directory changes#4085codyoss merged 3 commits intogoogleapis:masterfrom codyoss:filter-internal
codyoss merged 3 commits intogoogleapis:masterfrom
codyoss:filter-internal
Conversation
- Filter out internal dir changes since they do not need a module update. - Remove unneeded param from method - Log extra details when a excuting a command yields an error
google-cla
Bot
added
the
cla: yes
Member
Author
|
@noahdietz Can I get you to take a peek at this PR. It fixes a bug that is currently blocking regen. |
noahdietz
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update.