Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/gapicgen): filter out internal directory changes #4085

Merged
merged 3 commits into from May 12, 2021
Merged

fix(internal/gapicgen): filter out internal directory changes #4085

merged 3 commits into from May 12, 2021

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented May 11, 2021

  • Filter out internal dir changes since they do not need a module
    update.
  • Remove unneeded param from method
  • Log extra details when a excuting a command yields an error
- Filter out internal dir changes since they do not need a module
  update.
- Remove unneeded param from method
- Log extra details when a excuting a command yields an error
@codyoss codyoss requested a review from as a code owner May 11, 2021
@google-cla google-cla bot added the cla: yes label May 11, 2021
@codyoss codyoss requested a review from tbpg May 11, 2021
@codyoss
Copy link
Member Author

@codyoss codyoss commented May 12, 2021

@noahdietz Can I get you to take a peek at this PR. It fixes a bug that is currently blocking regen.

Loading

@codyoss codyoss merged commit 01473f6 into googleapis:master May 12, 2021
3 checks passed
Loading
@codyoss codyoss deleted the filter-internal branch May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants